Adding metadata to material page details and editions/details [DDFLSBP-543] #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clausbruun
changed the title
clausbruun
changed the title
clausbruun
changed the base branch from
release/brahma-15
to
release/brahma-15-1
spaceo
reviewed
May 8, 2024
| .map((contributor) => contributor.display) | ||
| .map((contributor) => { | ||
| if (contributor.roles.length > 0) { | ||
| const roleNames = contributor.roles |
There was a problem hiding this comment.
These TS errors are a bit alarming.
It seems like you did not run the FBI codegen cmd after updating the fragment?
There was a problem hiding this comment.
Hi @spaceo
The schema was updated in this commit: 0b2405e#diff-d7e14ab57cd19ae792d595c71bf36d4157c7fea99e0a7ea96e1003494b0baf6e 🙂
spaceo
reviewed
May 8, 2024
| .map((contributor) => { | ||
| if (contributor.roles.length > 0) { | ||
| const roleNames = contributor.roles | ||
| .map((role) => role.function.singular) |
spaceo
reviewed
May 8, 2024
| if (contributor.roles.length > 0) { | ||
| const roleNames = contributor.roles | ||
| .map((role) => role.function.singular) | ||
| .join(", "); |
spaceo
requested changes
May 8, 2024
clausbruun
deleted the
feature/DDFLSBP-543-se-vaerkvisningssiden-tilfojelse-af-metadata-under-se-detaljer-og-under-udgaver-detaljer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-543
Description
Adding metadata to material page details and editions/details:
Screenshot of the result
Additional info
The corresponding PR adding translation strings in
dpl-cmsis danskernesdigitalebibliotek/dpl-cms#1050